linux-kernel - Re: [tip:perf/urgent] perf: Fix perf mmap bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130605115538.GI27176@twins.programming.kicks-ass.net>
Date:	Wed, 5 Jun 2013 13:55:38 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	mingo@...nel.org, hpa@...or.com, paulus@...ba.org,
	linux-kernel@...r.kernel.org, acme@...stprotocols.net,
	viro@...iv.linux.org.uk, vincent.weaver@...ne.edu,
	tglx@...utronix.de
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/urgent] perf: Fix perf mmap bugs

On Tue, Jun 04, 2013 at 10:44:21AM +0200, Peter Zijlstra wrote:
> 
> Ingo asked for a delta against the patch already included in -tip.
> 
> Vince; perf_fuzzer crashed after about 5670000 iterations -- not sure
> you're aware it will crash at times. Anyway at this time accounting was
> still good.
> 
> ---
> Subject: perf: Fix mmap() accounting hole
> 
> Vince's fuzzer once again found holes. This time it spotted a leak in
> the locked page accounting.
> 
> When an event had redirected output and its close() was the last
> reference to the buffer we didn't have a vm context to undo accounting.
> 
> Change the code to destroy the buffer on the last munmap() and detach
> all redirected events at that time. This provides us the right context
> to undo the vm accounting.
> 
> Reported-by: Vince Weaver <vincent.weaver@...ne.edu>
> Signed-off-by: Peter Zijlstra <peterz@...radead.org>

Vince, can you confirm?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/