linux-kernel - Re: [PATCH] cpufreq: prevent 'policy->cpus' become offline in __gov_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1862476.P5VBB45STK@vostro.rjw.lan>
Date:	Wed, 05 Jun 2013 14:37:50 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Michael Wang <wangyun@...ux.vnet.ibm.com>
Cc:	Viresh Kumar <viresh.kumar@...aro.org>, cpufreq@...r.kernel.org,
	linux-pm@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Jiri Kosina <jkosina@...e.cz>, Borislav Petkov <bp@...en8.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	"tony.luck@...el.com" <tony.luck@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
	"paulmck@...ux.vnet.ibm.com" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH] cpufreq: prevent 'policy->cpus' become offline in __gov_queue_work()

On Wednesday, June 05, 2013 04:58:44 PM Michael Wang wrote:
> Hi, Viresh
> 
> On 06/05/2013 04:53 PM, Viresh Kumar wrote:
> [snip]
> >> It was caused by the policy->cpus changed during the process of
> >> __gov_queue_work(), in other word, cpu offline happened.
> >>
> >> This patch will use get/put_online_cpus() to prevent the offline
> >> happen inside __gov_queue_work(), after applied the patch, the
> >> warning is gone as Jiri tested:
> >>
> >>         Link: https://lkml.org/lkml/2013/6/5/88
> >>
> >> CC: "Rafael J. Wysocki" <rjw@...k.pl>
> >> CC: Viresh Kumar <viresh.kumar@...aro.org>
> >> Reported-by: Borislav Petkov <bp@...en8.de>
> >> Reported-by: Jiri Kosina <jkosina@...e.cz>
> >> Tested-by: Jiri Kosina <jkosina@...e.cz>
> >> Signed-off-by: Michael Wang <wangyun@...ux.vnet.ibm.com>
> >> ---
> >>  drivers/cpufreq/cpufreq_governor.c |    3 +++
> >>  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> 
> Thanks for your ack :)

Queued up for 3.10.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/