linux-kernel - Re: [PATCH 3/3] firmware loader: allow distribution to choose default search paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVPxJpjViUBHeM3qi_kndwiRc7qf1J-kEqTHE3mL7mpaRQ@mail.gmail.com>
Date:	Wed, 5 Jun 2013 20:36:19 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 3/3] firmware loader: allow distribution to choose default
 search paths

On Wed, Jun 5, 2013 at 7:57 PM, Takashi Iwai <tiwai@...e.de> wrote:
>
> Hmm, separating with semicolons isn't so common, but we can live with

Looks there are seldom such usage patterns in kernel, so could you let me
know which separator is more common?

> it.  I thought the previous loop can be kept but just pass each member
> to fw_get_file_firmware() unconditionally.  This will reduce the
> changes, I guess.  But it's just a matter of taste, here is no
> critically hot path, after all.

Yes, aother way is to move 'fw_path_para' out of fw_path[], and only
let  fw_get_fw_file_from_paths() deal with 'fw_path_para' and
CONFIG_FW_CUSTOMIZED_PATH. Looks it is still clean.


>> +             if (strstr(path, ".."))
>> +                     continue;
>
> I expect you'll prepare this path sanity check part in a separate
> patch, right?  It's basically independent from the new kconfig.

Yes, it will be submitted as another patch, also I plan to add
the check on firmware_name in _request_firmware_prepare()
so that the similar problem can be found earlier.

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/