linux-kernel - Re: [PATCH 06/10] mmc: dw_mmc-pltfm: add Rockchip variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201306051611.21669.heiko@sntech.de>
Date:	Wed, 5 Jun 2013 16:11:21 +0200
From:	Heiko Stübner <heiko@...ech.de>
To:	Seungwon Jeon <tgih.jun@...sung.com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	"'John Stultz'" <john.stultz@...aro.org>,
	"'Thomas Gleixner'" <tglx@...utronix.de>,
	"'Mike Turquette'" <mturquette@...aro.org>,
	"'Jaehoon Chung'" <jh80.chung@...sung.com>,
	"'Chris Ball'" <cjb@...top.org>, linux-mmc@...r.kernel.org,
	"'Grant Likely'" <grant.likely@...aro.org>,
	"'Rob Herring'" <rob.herring@...xeda.com>,
	"'Linus Walleij'" <linus.walleij@...aro.org>,
	devicetree-discuss@...ts.ozlabs.org,
	"'Russell King'" <linux@....linux.org.uk>,
	"'Arnd Bergmann'" <arnd@...db.de>,
	"'Olof Johansson'" <olof@...om.net>
Subject: Re: [PATCH 06/10] mmc: dw_mmc-pltfm: add Rockchip variant

Am Mittwoch, 5. Juni 2013, 16:00:43 schrieb Seungwon Jeon:
> On 06/03/13 7:59 AM, Heiko Stübner wrote:
> > Cortex-A9 SoCs from Rockchip use a slightly modified variant of dw_mmc
> > controllers that seems to require the SDMMC_CMD_USE_HOLD_REG bit to
> > always be set.
> > 
> > There also seem to be no other modifications (additional register etc)
> > present, so to keep the footprint low, add this small variant to the
> > pltfm driver.
> > 
> > Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> > ---
> > 
> >  drivers/mmc/host/dw_mmc-pltfm.c |   48
> >  +++++++++++++++++++++++++++----------- 1 files changed, 34
> >  insertions(+), 14 deletions(-)
> > 
> > diff --git a/drivers/mmc/host/dw_mmc-pltfm.c
> > b/drivers/mmc/host/dw_mmc-pltfm.c index 0048da8..7d041b5 100644
> > --- a/drivers/mmc/host/dw_mmc-pltfm.c
> > +++ b/drivers/mmc/host/dw_mmc-pltfm.c
> > @@ -24,6 +24,16 @@
> > 
> >  #include "dw_mmc.h"
> > 
> > +
> > +static void dw_mci_rockchip_prepare_command(struct dw_mci *host, u32
> > *cmdr) +{
> > +	*cmdr |= SDMMC_CMD_USE_HOLD_REG;
> 
> Currently, SDMMC_CMD_USE_HOLD_REG is defined in dw_mmc-exynos.c
> It should be moved to dw_mmc.h

It's already done in another patch "mmc: dw_mmc: Add support DW SD/MMC driver 
on SOCFPGA" from Dinh Nguyen <dinguyen@...era.com>, which I therefore named as 
dependency in the cover letter.

Don't know if it's better to also include the move here again and let the 
merging person sort out the conflict?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/