linux-kernel - Re: [PATCH] i2c: Let users disable "Probe an I2C bus for certain devices"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51AF63C7.9070007@ti.com>
Date:	Wed, 5 Jun 2013 19:13:59 +0300
From:	Grygorii Strashko <grygorii.strashko@...com>
To:	Wolfram Sang <wsa@...-dreams.de>
CC:	<linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-omap@...r.kernel.org>
Subject: Re: [PATCH] i2c: Let users disable "Probe an I2C bus for certain
 devices"

Hi
On 06/04/2013 08:49 PM, Wolfram Sang wrote:
> On Tue, Jun 04, 2013 at 08:33:42PM +0300, Grygorii Strashko wrote:
>
>> Currently the I2C devices instantiation Method 3 "Probe an I2C bus for
>> certain devices" (see Documentation/i2c/instantiating-devices) is always
>> enabled for all platforms (boards) and can't be disabled.
> Not true. Set .class = 0 for your adapter. I always ask authors of new
> drivers if they really need to set .class to something.
>
Agree, sorry, my statement is wrong. it would be right to say
"..can't be disabled without kernel code modification".

Few notes here:
1) boot delay issue isn't related to new drivers. There are
hwmon/lm75.c, i2c/busses/i2c-gpio.c and i2c/busses/i2c-omap.c

2) Initially, I've fighted with it on TI K3.4 product kernel where
DT isn't supported yet. And first thing, which I've tried to do is to 
correct
.class parameter for adapter, but with assumption:
"Default behavior shouldn't be changed as I2C detection might be used by 
some
of OMAP boards".

I've started from i2c-omap.c and OMAP4/5 (my target). As result, I was 
need to make
changes in *7* files to set and pass platform parameter to i2c-omap.c 
driver which
will allow to change .class to 0 on demand.

At this point, I've realized that i still need to deal with i2c-gpio.c - 
which
is generic driver.

3) Thinking about Mainline: To reach the same target - no I2C detection 
- and taking
into account above assumption "No changes in default behavior"
the following will need to be done:
- change i2c-omap/i2c-gpio DT bindings and add parameter which will 
allow to change
   .class value for adapter. Not sure, it's possible because this parameter
   will be Linux and not HW specific (smth. like "i2c_disable_detection")
- update drivers i2c-omap/i2c-gpio to use "i2c_disable_detection"
- update OMAP4/5 DTS files

So, It seemed a good solution for me to add 6 lines of code in i2c-core.c
instead of doing all that stuff.

Thanks/sorry for your time.

- grygorii

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/