linux-kernel - [ 42/44] x86, um: Correct syscall table type attributes breaking gcc 4.8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130605211226.239834635@linuxfoundation.org>
Date:	Wed,  5 Jun 2013 14:12:40 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	linux-kernel@...r.kernel.org
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	stable@...r.kernel.org, Martin Pelikan <pelikan@...rkhole.cz>,
	Richard Weinberger <richard@....at>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Bernhard M. Wiedemann" <bwiedemann@...e.de>
Subject: [ 42/44] x86, um: Correct syscall table type attributes breaking gcc 4.8

3.4-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Martin Pelikan <pelikan@...rkhole.cz>

commit 9271b0b4b2044c6db06051fe60bc58cdd4f17c7c upstream.

The latest GCC 4.8 does some more checking on type attributes that
break the build for ARCH=um -> fill them in.  Specifically, the
"asmlinkage" attributes is now tested for consistency.

Signed-off-by: Martin Pelikan <pelikan@...rkhole.cz>
Link: http://lkml.kernel.org/r/1339269731-10772-1-git-send-email-pelikan@storkhole.cz
Acked-by: Richard Weinberger <richard@....at>
Signed-off-by: H. Peter Anvin <hpa@...or.com>
Cc: Bernhard M. Wiedemann <bwiedemann@...e.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
 arch/x86/um/sys_call_table_32.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/arch/x86/um/sys_call_table_32.c
+++ b/arch/x86/um/sys_call_table_32.c
@@ -39,9 +39,9 @@
 #undef __SYSCALL_I386
 #define __SYSCALL_I386(nr, sym, compat) [ nr ] = sym,

-typedef void (*sys_call_ptr_t)(void);
+typedef asmlinkage void (*sys_call_ptr_t)(void);

-extern void sys_ni_syscall(void);
+extern asmlinkage void sys_ni_syscall(void);

 const sys_call_ptr_t sys_call_table[] __cacheline_aligned = {
 	/*

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/