linux-kernel - Re: [PATCH] Staging: anrdroid: sync.c: fixed all checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 6 Jun 2013 09:06:28 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Aldo Iljazi <neonsync1@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: anrdroid: sync.c: fixed all checkpatch warnings

On Wed, Jun 05, 2013 at 11:45:59PM +0300, Aldo Iljazi wrote:
> Specifically fixed: 
> sync.c:128: WARNING: braces {} are not necessary for single statement blocks
> sync.c:879: WARNING: Prefer seq_puts to seq_printf
> sync.c:883: WARNING: Prefer seq_puts to seq_printf
> sync.c:898: WARNING: Prefer seq_puts to seq_printf
> sync.c:902: WARNING: Prefer seq_puts to seq_printf
> sync.c:943: WARNING: Prefer seq_puts to seq_printf
> sync.c:952: WARNING: Prefer seq_puts to seq_printf
> sync.c:956: WARNING: Prefer seq_puts to seq_printf
> sync.c:964: WARNING: Prefer seq_puts to seq_printf
> total: 9 warnings,
> 

This breaks the build and it doesn't apply to linux-next.  Please
be more careful in the future.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/