linux-kernel - [PATCH] [SCSI] mpt2sas: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 6 Jun 2013 17:53:16 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	"James E.J. Bottomley" <JBottomley@...allels.com>
Cc:	DL-MPTFusionLinux@....com, linux-scsi@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] [SCSI] mpt2sas: fix build warning

Fixes this warning:

drivers/scsi/mpt2sas/mpt2sas_scsih.c: In function ‘_scsih_sas_broadcast_primitive_event’:
drivers/scsi/mpt2sas/mpt2sas_scsih.c:5810:40: warning: unused variable ‘event_data’ [-Wunused-variable]

when CONFIG_SCSI_MPT2SAS_LOGGING is not enabled.

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 drivers/scsi/mpt2sas/mpt2sas_debug.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Equivalent patches for drivers/message/fusion/mptdebug.h and
drivers/scsi/mpt3sas/mpt3sas_debug.h would fix similar, but to me
theoretical, warnings.

diff --git a/drivers/scsi/mpt2sas/mpt2sas_debug.h b/drivers/scsi/mpt2sas/mpt2sas_debug.h
index 69cc7d0..18b9a0c 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_debug.h
+++ b/drivers/scsi/mpt2sas/mpt2sas_debug.h
@@ -79,7 +79,11 @@
 		CMD;						\
 }
 #else
-#define MPT_CHECK_LOGGING(IOC, CMD, BITS)
+#define MPT_CHECK_LOGGING(IOC, CMD, BITS)			\
+{								\
+	if (0)							\
+		CMD;						\
+}
 #endif /* CONFIG_SCSI_MPT2SAS_LOGGING */
 
 
-- 
1.8.1

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped