[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 6 Jun 2013 09:23:13 +0800
From: Wang YanQing <udknight@...il.com>
To: Pavel Machek <pavel@....cz>
Cc: gregkh@...uxfoundation.org, sfr@...b.auug.org.au,
linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] TTY:vt: convert remain take_over_console's users to
do_take_over_console
On Tue, Jun 04, 2013 at 10:13:18PM +0200, Pavel Machek wrote:
> On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
> > Impact:
> > 1:convert all remain take_over_console to do_take_over_console
>
> This is step backwards.
What is step backwards? do_take_over_console appear MUCH MUCH later in kernel
than take_over_console, do_take_over_console is the new API, I can't understand
what is step backwards.
> > --- a/arch/alpha/kernel/console.c
> > +++ b/arch/alpha/kernel/console.c
> > @@ -61,7 +61,9 @@ locate_and_init_vga(void *(*sel_func)(void *, void *))
> >
> > /* Set the VGA hose and init the new console. */
> > pci_vga_hose = hose;
> > - take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1);
> > + console_lock();
> > + do_take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1);
> > + console_unlock();
> > }
>
> Original was better.
Except reduce some console_lock/unlock scatter scattered in kernel, I
can't see the "BETTER", and it is not a BIG problem for the benefit to
unify the API.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists