linux-kernel - Re: [PATCH] GFS2: minor readability improvement in gfs2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 06 Jun 2013 10:24:42 +0100
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:	cluster-devel@...hat.com, linux-kernel@...r.kernel.org,
	ldv-project@...uxtesting.org
Subject: Re: [PATCH] GFS2: minor readability improvement in gfs2_mount()

Hi,

On Thu, 2013-06-06 at 01:29 +0400, Alexey Khoroshilov wrote:
> The patch makes usage pattern of IS_ERR-PTR_ERR more typical.
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
> ---
>  fs/gfs2/ops_fstype.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> index 0262c19..0d30e8e 100644
> --- a/fs/gfs2/ops_fstype.c
> +++ b/fs/gfs2/ops_fstype.c
> @@ -1313,9 +1313,10 @@ static struct dentry *gfs2_mount(struct file_system_type *fs_type, int flags,
>  	}
>  	s = sget(fs_type, test_gfs2_super, set_gfs2_super, flags, bdev);
>  	mutex_unlock(&bdev->bd_fsfreeze_mutex);
> -	error = PTR_ERR(s);
> -	if (IS_ERR(s))
> +	if (IS_ERR(s)) {
> +		error = PTR_ERR(s);
>  		goto error_bdev;
> +	}
I'm not sure what you are getting at here. Why add a jump into the fast
path?

Steve.

>  
>  	if (s->s_root)
>  		blkdev_put(bdev, mode);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/