lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Jun 2013 23:01:21 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Heiko Stübner <heiko@...ech.de> Cc: "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, John Stultz <john.stultz@...aro.org>, Thomas Gleixner <tglx@...utronix.de>, Mike Turquette <mturquette@...aro.org>, Seungwon Jeon <tgih.jun@...sung.com>, Jaehoon Chung <jh80.chung@...sung.com>, Chris Ball <cjb@...top.org>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, Grant Likely <grant.likely@...aro.org>, Rob Herring <rob.herring@...xeda.com>, Linus Walleij <linus.walleij@...aro.org>, Devicetree Discuss <devicetree-discuss@...ts.ozlabs.org>, Russell King <linux@....linux.org.uk>, Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net> Subject: Re: [PATCH 06/10] mmc: dw_mmc-pltfm: add Rockchip variant On Mon, Jun 3, 2013 at 1:59 AM, Heiko Stübner <heiko@...ech.de> wrote: > Cortex-A9 SoCs from Rockchip use a slightly modified variant of dw_mmc > controllers that seems to require the SDMMC_CMD_USE_HOLD_REG bit to > always be set. > > There also seem to be no other modifications (additional register etc) > present, so to keep the footprint low, add this small variant to the > pltfm driver. Few comments below. > --- a/drivers/mmc/host/dw_mmc-pltfm.c > +++ b/drivers/mmc/host/dw_mmc-pltfm.c > @@ -24,6 +24,16 @@ > > #include "dw_mmc.h" > > + No need to add extra empty line here. > +static void dw_mci_rockchip_prepare_command(struct dw_mci *host, u32 *cmdr) > @@ -63,20 +73,6 @@ int dw_mci_pltfm_register(struct platform_device *pdev, > } > EXPORT_SYMBOL_GPL(dw_mci_pltfm_register); > > -static int dw_mci_pltfm_probe(struct platform_device *pdev) > -{ > - return dw_mci_pltfm_register(pdev, NULL); > -} > - > -int dw_mci_pltfm_remove(struct platform_device *pdev) > -{ > - struct dw_mci *host = platform_get_drvdata(pdev); > - > - dw_mci_remove(host); > - return 0; > -} > -EXPORT_SYMBOL_GPL(dw_mci_pltfm_remove); > - If you want to move those through code, please do separate patch. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists