[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 06 Jun 2013 15:18:13 -0500
From: Jesse Larrew <jlarrew@...ux.vnet.ibm.com>
To: Dave Jones <davej@...hat.com>,
"Michael S. Tsirkin" <mst@...hat.com>,
Rusty Russell <rusty@...tcorp.com.au>,
"David S. Miller" <davem@...emloft.net>,
Jason Wang <jasowang@...hat.com>,
Cong Wang <amwang@...hat.com>, Amos Kong <akong@...hat.com>,
virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, qemu-devel@...gnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline
with data
On 06/06/2013 03:09 PM, Dave Jones wrote:
> On Thu, Jun 06, 2013 at 02:59:44PM -0500, Jesse Larrew wrote:
>
> > > pr_debug("%s: xmit %p %pM\n", vi->dev->name, skb, dest);
> > > + if (vi->mergeable_rx_bufs)
> > > + hdr_len = sizeof hdr->mhdr;
> > > + else
> > > + hdr_len = sizeof hdr->hdr;
> >
> > All conditionals need braces.
>
> Documentation/CodingStyle disagrees:
>
> "Do not unnecessarily use braces where a single statement will do."
>
> Dave
>
Ah, yes. This is kernel code. My mistake. :)
Jesse Larrew
Software Engineer, KVM Team
IBM Linux Technology Center
Phone: (512) 973-2052 (T/L: 363-2052)
jlarrew@...ux.vnet.ibm.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists