linux-kernel - Re: [PATCH 3/6] keucr: migrate printk to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Jun 2013 00:14:22 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Johannes Schilling <of82ecuq@....cs.fau.de>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Kurt Kanzenbach <shifty91@...il.com>,
	linux-kernel@...cs.fau.de,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Al Cho <acho@...ell.com>,
	Amarjargal Gundjalam <amarjargal16@...il.com>,
	Laura Lawniczak <laura.lawniczak@...glemail.com>
Subject: Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

On Thu, Jun 06, 2013 at 06:10:47PM +0200, Johannes Schilling wrote:
> @@ -321,7 +320,7 @@ int ENE_Write_Data(struct us_data *us, void *buf, unsigned int length)
>  /*
>   * usb_stor_print_cmd():
>   */
> -void usb_stor_print_cmd(struct scsi_cmnd *srb)
> +void usb_stor_print_cmd(struct us_data *us,struct scsi_cmnd *srb)
                                             ^^
Missing space.  Run checkpatch.pl over your patch to find these.
This can be fixed in a later patch I think.

>  {
>  	PBYTE	Cdb = srb->cmnd;
>  	DWORD	cmd = Cdb[0];

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/