linux-kernel - Re: [PATCH 5/6] keucr: moved function to other file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Jun 2013 00:23:46 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Johannes Schilling <of82ecuq@....cs.fau.de>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Kurt Kanzenbach <shifty91@...il.com>,
	linux-kernel@...cs.fau.de,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Al Cho <acho@...ell.com>,
	Amarjargal Gundjalam <amarjargal16@...il.com>,
	Laura Lawniczak <laura.lawniczak@...glemail.com>
Subject: Re: [PATCH 5/6] keucr: moved function to other file

On Thu, Jun 06, 2013 at 06:10:49PM +0200, Johannes Schilling wrote:
> From: Laura Lawniczak <laura.lawniczak@...glemail.com>
> 
> Function usb_stor_print_cmd was declared in init.c but only used
> in transport.c. So it was reasonable to move it there and declare
> it static
> 
> Signed-off-by: Laura Lawniczak <laura.lawniczak@...glemail.com>

Don't forget your Signed-off-by, Johannes, since it's coming from
you.  Can you resend this?

There are a couple small changes between the original and the moved
function.
1) "blen = 0" is removed from the last line.  This doesn't cause a
   bug.  In a later patch you can remove the "bn = 0" as well.
2) A comma was deleted after the string in the commented code so it
   now has a syntax error:

> +		/*  dev_dbg(
> +			    &us->pusb_dev->dev, "scsi cmd %X --- SCSIOP_READ,bn = %X, blen = %X\n"
> +			    cmd, bn, blen); */

It's better if you just do a straight move and change things in a
later patch.  But for now it's fine.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/