[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <51B2054B.7030609@nvidia.com>
Date: Fri, 7 Jun 2013 12:07:39 -0400
From: Rhyland Klein <rklein@...dia.com>
To: Andrew Chew <achew@...dia.com>
CC: "cbou@...l.ru" <cbou@...l.ru>,
"dwmw2@...radead.org" <dwmw2@...radead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH 1/1] tps65090-charger: Fix AC detect
On 6/6/2013 5:12 PM, Andrew Chew wrote:
> The VACG interrupt was not being enabled. Thus, interrupts were never
> generated when AC status changes. In addition, interrupts were never
> cleared after taking and processing the interrupt.
>
> Added the register offset for the INTR_MASK register, since this is needed
> to unmask the VACG interrupt.
>
> Enabled the VACG interrupt in tps65090_config_charger().
>
> Cleared interrupts after processing, in tps65090_charger_isr().
>
> Also removed unused variable "enable" in tps65090_enable_charging(),
> and fixed a typo in one of the dev_err() prints.
>
> Signed-off-by: Andrew Chew <achew@...dia.com>
> ---
Great! Tested and it works great on my Dalmore.
Tested-by: Rhyland Klein <rklein@...dia.com>
Acked-by: Rhyland Klein <rklein@...dia.com>
-rhyland
--
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists