linux-kernel - Re: [PATCH v2 2/3] USB: serial: make minor allocation dynamic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130607172458.GA29371@kroah.com>
Date:	Fri, 7 Jun 2013 10:24:58 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Johan Hovold <jhovold@...il.com>
Cc:	Tobias Winter <tobias@...uxdingsda.de>,
	Bjørn Mork <bjorn@...k.no>,
	Rob Landley <rob@...dley.net>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] USB: serial: make minor allocation dynamic

On Fri, Jun 07, 2013 at 12:00:47PM +0200, Johan Hovold wrote:
> On Thu, Jun 06, 2013 at 10:31:21AM -0700, Greg KH wrote:
> > From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> > @@ -1040,11 +1044,10 @@ static int usb_serial_probe(struct usb_i
> >  	 */
> >  	serial->disconnected = 1;
> >  
> > -	if (get_free_serial(serial, num_ports, &minor) == NULL) {
> > +	if (get_free_serial(serial, num_ports)) {
> >  		dev_err(ddev, "No more free serial devices\n");
> >  		goto probe_error;
> >  	}
> > -	serial->minor = minor;
> 
> This gives a warning as minor is no longer initialised, but is still
> used to initialise the console a bit further down.
> 
> 	usb_serial_console_init(minor);
> 
> Should probably just drop minor, and use serial->port[0]->minor instead.

Ah crap, I knew I was going to have to convert the console code, but I
just forgot about it as I didn't have it selected so I didn't get any
build errors...

I'll go fix that up and do a v3 of the patches...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/