linux-kernel - Re: [PATCH] power: Add missing newlines, fix a couple of typos, add pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+YwLHzETz4kkSFU0bJRWgR44qtypc8vDGJX5tvhm1khw@mail.gmail.com>
Date:	Fri, 7 Jun 2013 11:31:06 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Anton Vorontsov <anton@...msg.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jens Axboe <axboe@...nel.dk>,
	"David S. Miller" <davem@...emloft.net>,
	Herbert Xu <herbert@...dor.hengli.com.au>,
	David Woodhouse <dwmw2@...radead.org>,
	Karsten Keil <isdn@...ux-pingi.de>,
	"# 3.4.x" <stable@...r.kernel.org>
Subject: Re: [PATCH] power: Add missing newlines, fix a couple of typos, add pr_fmt

On Thu, Jun 6, 2013 at 6:25 PM, Joe Perches <joe@...ches.com> wrote:
> Make sure that dev_<level> calls are newline terminated.
> Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt to prefix
> all pr_<level> calls with "charger-manager: "
>
> Fix a couple of typos.
> Fix formats with terminating n that should be \n.
> Coalesce formats for easier grep.
> Align arguments to open parenthesis for these dev_<level> calls.
> Add missing spaces after coalescing multiple string segments.
>
> Signed-off-by: Joe Perches <joe@...ches.com>

Looks like good clean-ups.

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/