linux-kernel - Re: kernel/workqueue.c:4435:61: sparse: expression using sizeof bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20130607235003.GA7234@localhost>
Date:	Sat, 8 Jun 2013 07:50:03 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, kbuild-all@...org,
	Christopher Li <sparse@...isli.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: kernel/workqueue.c:4435:61: sparse: expression using sizeof bool

On Fri, Jun 07, 2013 at 03:03:51PM -0700, Tejun Heo wrote:
> On Fri, Jun 07, 2013 at 02:15:21PM -0700, Andrew Morton wrote:
> > >   4434		/* copy worker description */
> > > > 4435		probe_kernel_read(&desc_valid, &worker->desc_valid, sizeof(desc_valid));
> > 
> > I don't understand the rationale for the sparse test, really.  This
> > code seems unproblematic.
> 
> Yeah, I've gotten that warning a couple times now and am just ignoring
> it at this point.  Maybe the standard says bool isn't a proper
> integeral type and its size isn't precisely defined or something?  I
> don't know.

Hmm, I'd better disable the warnings that are normally ignored anyway..

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/