linux-kernel - Re: [ 061/184] PCI/PM: Clean up PME state when removing a device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130607053740.GG14633@1wt.eu>
Date:	Fri, 7 Jun 2013 07:37:40 +0200
From:	Willy Tarreau <w@....eu>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [ 061/184] PCI/PM: Clean up PME state when removing a device

On Fri, Jun 07, 2013 at 05:23:56AM +0100, Ben Hutchings wrote:
> On Tue, 2013-06-04 at 19:22 +0200, Willy Tarreau wrote:
> > 2.6.32-longterm review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: "Rafael J. Wysocki" <rjw@...k.pl>
> > 
> > commit 249bfb83cf8ba658955f0245ac3981d941f746ee upstream.
> > 
> > Devices are added to pci_pme_list when drivers use pci_enable_wake()
> > or pci_wake_from_d3(), but they aren't removed from the list unless
> > the driver explicitly disables wakeup.  Many drivers never disable
> > wakeup, so their devices remain on the list even after they are
> > removed, e.g., via hotplug.  A subsequent PME poll will oops when
> > it tries to touch the device.
> > 
> > This patch disables PME# on a device before removing it, which removes
> > the device from pci_pme_list.  This is safe even if the device never
> > had PME# enabled.
> 
> There's no such list in 2.6.32, so I don't think this is needed.

Dropped, thanks !

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/