linux-kernel - Re: [PATCH 1/2] PM: use dpm_run_callback in device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130608011518.GA2819@kroah.com>
Date:	Fri, 7 Jun 2013 18:15:18 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Yanmin Zhang <yanmin_zhang@...ux.intel.com>
Cc:	shuox.liu@...el.com, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, pavel@....cz, rjw@...k.pl,
	len.brown@...el.com, Zhang Yanmin <yanmin.zhang@...el.com>
Subject: Re: [PATCH 1/2] PM: use dpm_run_callback in device_prepare

On Sat, Jun 08, 2013 at 08:43:55AM +0800, Yanmin Zhang wrote:
> On Fri, 2013-06-07 at 10:37 -0700, Greg KH wrote:
> > On Fri, Jun 07, 2013 at 04:20:31PM +0800, shuox.liu@...el.com wrote:
> > > From: ShuoX Liu <shuox.liu@...el.com>
> > > 
> > > dpm_run_callback could show more debug info around prepare stage.
> > 
> > Why?  Who needs this?  What problem does it solve?
> > 
> > Without answers to this, why would you expect us to accept such a
> > change?
> It's to provide more debug info and developers can quickly find what
> prepare/complete callback consumes too much time.

What exact debug info is this providing, and why wouldn't you say all of
this in the original changelog information?

{hint}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/