linux-kernel - Re: [PATCH v2 0/3] Increase the number of USB to serial devices we can support at once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 08 Jun 2013 11:14:47 +0200
From:	Tobias Winter <tobias@...uxdingsda.de>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	Bjørn Mork <bjorn@...k.no>,
	Rob Landley <rob@...dley.net>,
	Johan Hovold <jhovold@...il.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] Increase the number of USB to serial devices we
 can support at once

On 06/07/2013 07:25 PM, Greg KH wrote:
> On Fri, Jun 07, 2013 at 11:55:59AM +0200, Tobias Winter wrote:
>> On 06/07/2013 08:00 AM, Tobias Winter wrote:
>>>   CC      drivers/usb/serial/console.o
>>> drivers/usb/serial/console.c: In function ‘usb_console_setup’:
>>> drivers/usb/serial/console.c:111:2: error: implicit declaration of
>>> function ‘usb_serial_get_by_index’ [-Werror=implicit-function-declaration]
>>> drivers/usb/serial/console.c:111:9: warning: assignment makes pointer
>>> from integer without a cast [enabled by default]
>>> drivers/usb/serial/console.c:122:40: error: ‘struct usb_serial’ has no
>>> member named ‘minor’
>>> cc1: some warnings being treated as errors
>>> make[4]: *** [drivers/usb/serial/console.o] Error 1
>>> make[3]: *** [drivers/usb/serial] Error 2
>>> make[2]: *** [drivers/usb] Error 2
>>> make[1]: *** [drivers] Error 2
>>> make[1]: Leaving directory `/root/usb.git'
>>> make: *** [debian/stamp/build/kernel] Error 2
>>
>> Despite that broken driver, I just gave it a try and the patchset works
>> as expected.
> 
> Thanks for testing, I forgot to update the console code, as no one sane
> every runs it :)
> 
> I'll go fix that up now...
I just retested it and it works as expected.

Thanks, Greg!

Tobias


Download attachment "signature.asc" of type "application/pgp-signature" (264 bytes)