linux-kernel - [Suggestion] arch/*/include/asm/bitops.h: about __set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <51B30285.6020503@asianux.com>
Date:	Sat, 08 Jun 2013 18:08:05 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	rth@...ddle.net, ink@...assic.park.msu.ru, mattst88@...il.com,
	"dhowells@...hat.com" <dhowells@...hat.com>, tony.luck@...el.com,
	fenghua.yu@...el.com, yasutake.koichi@...panasonic.com
CC:	linux-alpha@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-ia64@...r.kernel.org, linux-am33-list@...hat.com,
	Linux-Arch <linux-arch@...r.kernel.org>
Subject: [Suggestion] arch/*/include/asm/bitops.h: about __set_bit() API.

Hello Maintainers:


Several architectures have different __set_bit() API to others, in
standard API, 2nd param of __set_bit() is 'unsigned long *', but:

  in 'min10300', it is 'unsigned char *',
  in 'ia64' and 'alpha', they are 'int' or 'unsigned int'.

If another sub-systems did not notice it, it may lead them to make
mistakes.

It seems related maintainer intended to implement it like that.

So could related maintainers provide the reason for it, so more guys
(e.g. me) can learn about it (at least can avoid related mistakes).


The related information in arch sub-system:

using 'unsigned char *':
  ./mn10300/include/asm/bitops.h:28:#define __set_bit(nr, addr)					\

using 'unsigned int *', implicitly: 
  ./ia64/include/asm/bitops.h:63:__set_bit (int nr, volatile void *addr)

using 'int *', implicitly: (need use 'unsigned', at least)
  ./alpha/include/asm/bitops.h:49:__set_bit(unsigned long nr, volatile void * addr)

using 'unsigned long *' implicitly:
  ./frv/include/asm/bitops.h:164:static inline void __set_bit(unsigned long nr, volatile void *addr)
  
standard API:  
  ./h8300/include/asm/bitops.h:74:#define __set_bit(nr,addr)    set_bit((nr),(addr))
  ./m68k/include/asm/bitops.h:67:#define __set_bit(nr, vaddr)	set_bit(nr, vaddr)
  ./arc/include/asm/bitops.h:293:static inline void __set_bit(unsigned long nr, volatile unsigned long *m)
  ./sh/include/asm/bitops-op32.h:20:static inline void __set_bit(int nr, volatile unsigned long *addr)
  ./hexagon/include/asm/bitops.h:151:static inline void __set_bit(int nr, volatile unsigned long *addr)
  ./s390/include/asm/bitops.h:212:static inline void __set_bit(unsigned long nr, volatile unsigned long *ptr)
  ./x86/include/asm/bitops.h:84:static inline void __set_bit(int nr, volatile unsigned long *addr)
  (others use 'generic')


Thanks.
-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/