| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 08 Jun 2013 12:46:01 +0200
From: Tomasz Figa <tomasz.figa@...il.com>
To: Tushar Behera <tushar.behera@...aro.org>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, kgene.kim@...sung.com,
patches@...aro.org, Sachin Kamat <sachin.kamat@...aro.org>
Subject: Re: [PATCH 1/3] ARM: dts: exynos4210: Add LCD related pinctrl entries
Hi Tushar, Sachin,
On Friday 07 of June 2013 16:37:13 Tushar Behera wrote:
> From: Sachin Kamat <sachin.kamat@...aro.org>
>
> Adds pinctrl entries required by FIMD.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
> Signed-off-by: Tushar Behera <tushar.behera@...aro.org>
> ---
> arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 75
> +++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi index 55a2efb..d241726
> 100644
> --- a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> @@ -330,6 +330,81 @@
> samsung,pin-pud = <3>;
> samsung,pin-drv = <0>;
> };
> +
> + pwm0_out: pwm0-out {
> + samsung,pins = "gpd0-0";
> + samsung,pin-function = <2>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> +
> + pwm1_out: pwm1-out {
> + samsung,pins = "gpd0-1";
> + samsung,pin-function = <2>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
Hmm, these two seem to be unrelated. Rebase error? :)
> + lcd_ctrl: lcd-ctrl {
> + samsung,pins = "gpd0-0", "gpd0-1";
> + samsung,pin-function = <3>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> +
> + lcd_sync: lcd-sync {
> + samsung,pins = "gpf0-0", "gpf0-1";
> + samsung,pin-function = <2>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> +
> + lcd_en: lcd-en {
> + samsung,pins = "gpe3-4";
> + samsung,pin-function = <2>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> +
> + lcd_clk: lcd-clk {
> + samsung,pins = "gpf0-0", "gpf0-1", "gpf0-2",
"gpf0-3";
> + samsung,pin-function = <2>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> +
> + lcd_data16: lcd-data-width16 {
> + samsung,pins = "gpf0-7", "gpf1-0", "gpf1-1",
"gpf1-2",
> + "gpf1-3", "gpf1-6", "gpf1-7",
"gpf2-0",
> + "gpf2-1", "gpf2-2", "gpf2-3",
"gpf2-7",
> + "gpf3-0", "gpf3-1", "gpf3-2",
"gpf3-3";
> + samsung,pin-function = <2>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> +
> + lcd_data18: lcd-data-width18 {
> + samsung,pins = "gpf0-6", "gpf0-7", "gpf1-0",
"gpf1-1",
> + "gpf1-2", "gpf1-3", "gpf1-6",
"gpf1-7",
> + "gpf2-0", "gpf2-1", "gpf2-2",
"gpf2-3",
> + "gpf2-6", "gpf2-7", "gpf3-0",
"gpf3-1",
> + "gpf3-2", "gpf3-3";
> + samsung,pin-function = <2>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> +
> + lcd_data24: lcd-data-width24 {
> + samsung,pins = "gpf0-4", "gpf0-5", "gpf0-6",
"gpf0-7",
> + "gpf1-0", "gpf1-1", "gpf1-2",
"gpf1-3",
> + "gpf1-4", "gpf1-5", "gpf1-6",
"gpf1-7",
> + "gpf2-0", "gpf2-1", "gpf2-2",
"gpf2-3",
> + "gpf2-4", "gpf2-5", "gpf2-6",
"gpf2-7",
> + "gpf3-0", "gpf3-1", "gpf3-2",
"gpf3-3";
> + samsung,pin-function = <2>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> };
>
> pinctrl@...00000 {
Otherwise looks good to me.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists