linux-kernel - Re: [PATCH v2] ethernet/arc/arc_emac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51B31442.5020707@synopsys.com>
Date:	Sat, 8 Jun 2013 16:53:46 +0530
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
CC:	Joe Perches <joe@...ches.com>,
	Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Vineet Gupta <Vineet.Gupta1@...opsys.com>,
	"Mischa Jonker" <Mischa.Jonker@...opsys.com>,
	Arnd Bergmann <arnd@...db.de>,
	"Grant Likely" <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	"David S. Miller" <davem@...emloft.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"romieu@...zoreil.com" <romieu@...zoreil.com>
Subject: Re: [PATCH v2] ethernet/arc/arc_emac - Add new driver

On 06/08/2013 04:49 PM, Alexey Brodkin wrote:
>  >> +	if (!priv->phy_node) {
>  >> +		dev_err(&pdev->dev, "failed to retrieve phy description "
>  >> +			"from device tree\n");
>  >
>  > Coalesce formats please
>
> Could you please clarify how should I format lines in question?
> I'm a bit lost here.

Don't break the string - even if line becomes > 80 chars. This is to help with
grep and such.

-Vineet
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/