linux-kernel - Re: [PATCH] pcmcia: pd6729: fix error return code in pd6729_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfOzDEfcDXSLYFQO0k3_v9ghw6oXrWeSxfB5T5ph6mg0Q@mail.gmail.com>
Date:	Sun, 9 Jun 2013 19:09:00 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	Bill Pemberton <wfp5p@...ginia.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Eric Miao <eric.y.miao@...il.com>,
	yongjun_wei@...ndmicro.com.cn, linux-pcmcia@...ts.infradead.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pcmcia: pd6729: fix error return code in pd6729_pci_probe()

On Fri, Jun 7, 2013 at 5:16 AM, Wei Yongjun <weiyj.lk@...il.com> wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.

What about to move the driver to pcim_*/devm_* functions?

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/