linux-kernel - Re: [PATCH] pwm: devm: alloc correct pointer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130610105114.GA2572@manwe>
Date:	Mon, 10 Jun 2013 12:51:14 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Wolfram Sang <wsa@...-dreams.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pwm: devm: alloc correct pointer size

On Mon, Jun 10, 2013 at 09:41:52AM +0300, Andy Shevchenko wrote:
> On Mon, Jun 10, 2013 at 3:04 AM, Wolfram Sang <wsa@...-dreams.de> wrote:
> > On Thu, Jun 06, 2013 at 10:43:41PM +0300, Andy Shevchenko wrote:
> >> On Mon, Jun 3, 2013 at 11:27 PM, Wolfram Sang <wsa@...-dreams.de> wrote:
> >> > The allocated object should be the size of what the pointer is pointing
> >> > to and not the size of the pointer itself.
> >>
> >> All devm_* functions in this module use **ptr as a parameter (except
> >> allocation).
> >> May be we first should understand why it so?
> >
> > Huh? **ptr is already created on the stack, but assigned the alloced
> > memory. Later, the mem it points to is set to 'pwm' which is then added
> > to devres. So, the alloced memory must be able to contain '*ptr' (or
> > *pwm which would be more readable IMO, but other subsystems also stick
> > to *ptr), no?
> 
> Yes, you right.
> Take my Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

Applied, thanks.

Thierry

Content of type "application/pgp-signature" skipped