linux-kernel - Re: [PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130610154817.3275672f@holzheu>
Date:	Mon, 10 Jun 2013 15:48:17 +0200
From:	Michael Holzheu <holzheu@...ux.vnet.ibm.com>
To:	HATAYAMA Daisuke <d.hatayama@...il.com>
Cc:	Vivek Goyal <vgoyal@...hat.com>, Jan Willeke <willeke@...ibm.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux-kernel@...r.kernel.org, kexec@...ts.infradead.org
Subject: Re: [PATCH v5 2/5] s390/vmcore: Use ELF header in new memory
 feature

On Mon, 10 Jun 2013 22:36:57 +0900
HATAYAMA Daisuke <d.hatayama@...il.com> wrote:

> > -static int setup_kdump_elfcorehdr(void)
> > +void elfcorehdr_free(void)
> >  {
> > -       size_t elfcorebuf_sz;
> > -       char *elfcorebuf;
> > -
> > -       if (!OLDMEM_BASE || is_kdump_kernel())
> > -               return -EINVAL;
> > -       s390_elf_corehdr_create(&elfcorebuf, &elfcorebuf_sz);
> > -       elfcorehdr_addr = (unsigned long long) elfcorebuf;
> > -       elfcorehdr_size = elfcorebuf_sz;
> > -       return 0;
> > +       if (!elfcorehdr_newmem)
> > +               return;
> > +       vfree(elfcorehdr_newmem);  
> 
> kfree is correct here?

You are right, I fixed that!

Thanks!
Michael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/