linux-kernel - Re: [PATCH v2 1/2] ARM: dts: add dtsi for palmas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51B5FEDE.5070900@wwwdotorg.org>
Date:	Mon, 10 Jun 2013 10:29:18 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	J Keerthy <j-keerthy@...com>
CC:	b-cousson@...com, devicetree-discuss@...ts.ozlabs.org,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	ldewangan@...dia.com, grant.likely@...retlab.ca,
	swarren@...dia.com, sameo@...ux.intel.com, gg@...mlogic.co.uk,
	lee.jones@...aro.org
Subject: Re: [PATCH v2 1/2] ARM: dts: add dtsi for palmas

On 06/10/2013 03:04 AM, J Keerthy wrote:
> Adds palmas mfd and palmas regulator nodes.

Nits:

Well, you're really adding files that provide the nodes, not the nodes
themselves.

Palmas and MFD should be correctly capitalized.

> diff --git a/arch/arm/boot/dts/palmas.dtsi b/arch/arm/boot/dts/palmas.dtsi

> +&palmas {
...
> +	palmas_pmic {
...
> +		ti,ldo6-vibrator;

Isn't that board-specific? I don't know the HW well enough to say, but I
assume that since there's a property, the whole point must be that some
boards want it set and some don't.

> +		regulators {
> +			smps123_reg: smps123 {
> +				regulator-name = "smps123";
> +			};

So the node labels here duplicate those in omap5-uevm.dts in patch 2/2.
While dtc allows this, I don't think there's much point duplicating the
labels. I'd tend to only put the labels in omap5-uevm.dts and not put
them here. That will completely avoid the possibility of the labels in
this file from conflicting with any other labels in any top-level
board.dts file.

I also wonder if this file is actually terribly useful. The only thing
that this file provides is the regulator-name property. It seems simpler
just to put that into each board.dts file. The added advantage of doing
that, is that if a board doesn't use a particular regulator, the node
won't appear, and the regulator won't get registered.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/