linux-kernel - Re: [PATCH 3/3] MMC: FSL SDHC: Add support for hard-wired (permanent) card. Kernel version 3.4.47

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51B60276.5040002@advaoptical.com>
Date:	Mon, 10 Jun 2013 19:44:38 +0300
From:	Oded Gabbay <ogabbay@...aoptical.com>
To:	Dirk Behme <dirk.behme@...bosch.com>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"cjb@...top.org" <cjb@...top.org>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"rob@...dley.net" <rob@...dley.net>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH 3/3] MMC: FSL SDHC: Add support for hard-wired (permanent)
 card. Kernel version 3.4.47

Hi All,

Just noticed that 3.4.47/8 doesn't have the mmc_of_parse (compared to 
3.9.4).
Therefore, I will not use it and just fix the code to recognize the 
property "non-removable"

Best regards,
Oded

On 06/10/2013 04:43 PM, Oded Gabbay wrote:
> Hi Dirk,
>
> You are absolutely right.
> I will revise my patch series to reflect the change.
> Basically, I will call the generic mmc_of_parse from the probe 
> function of Freescale's driver.
> That will handle all the additional capabilities.
>
> Thanks
> Oded
>
> On 06/10/2013 09:29 AM, Dirk Behme wrote:
>> On 02.06.2013 08:38, Oded Gabbay wrote:
>>> This patch adds support of recognizing hard-wired (permanent) cards
>>> to Freescale's SDHC host driver. This is done by adding the option
>>> "fsl,card-wired" to the SDHC device-tree entry. Detection of this
>>> option is done in the probe function. Update documentation in file
>>> fsl-esdhc.txt
>>
>> Why don't you want to introduce "fsl,card-wired"? Why don't you use 
>> "non-removable"?
>>
>> To my understanding the patch
>>
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7f217794ffa72f208a250b79ab0b7ea3de19677f 
>>
>>
>> explicitly removed "fsl,card-wired". So I don't think re-introducing 
>> it is a good idea?
>>
>> Best regards
>>
>> Dirk
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/