linux-kernel - Re: [PATCH] ipc: don't allocate with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1370885029.1795.7.camel@buesod1.americas.hpqcorp.net>
Date:	Mon, 10 Jun 2013 10:23:49 -0700
From:	Davidlohr Bueso <davidlohr.bueso@...com>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	akpm@...ux-foundation.org, riel@...hat.com, walken@...gle.com,
	linux-kernel@...r.kernel.org, Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH] ipc: don't allocate with GFP_KERNEL inside rcu read lock

On Mon, 2013-06-10 at 12:14 -0400, Sasha Levin wrote:
> ipc_addid() is protected by a rcu read lock, which means we can't allocate
> using GFP_KERNEL inside it.
> 
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
> ---
> 
> Another option would be to call idr_preload from outside the read lock,
> but that complicates the code much more than this fix. If that's the
> preferred method to fix it I can resend that solution instead.
> 

This issue was reported last week by Fengguang
(http://www.spinics.net/lists/kernel/msg1545633.html#.UbYI9qqdmV8)

Your fix looks the simplest approach, but I'm not sure if doing the
atomic allocation would trigger some other problem, as a side effect.
Andrew?

A third option would be to simply revert the offending commit, leaving
the rcu locking as it originally was.

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/