lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <51B60D25.2000302@metafoo.de>
Date:	Mon, 10 Jun 2013 19:30:13 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	Ralf Baechle <ralf@...ux-mips.org>,
	Vinod Koul <vinod.koul@...el.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Maarten ter Huurne <maarten@...ewalker.org>,
	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH v2 4/6] MIPS: jz4740: Register jz4740 DMA device

On 05/30/2013 07:24 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 05/30/2013 08:25 PM, Lars-Peter Clausen wrote:
> 
>> Register a device for the newly added jz4740 dmaengine driver.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
>> Acked-by: Ralf Baechle <ralf@...ux-mips.org>
> [...]
>>   3 files changed, 23 insertions(+)
>> diff --git a/arch/mips/jz4740/platform.c b/arch/mips/jz4740/platform.c
>> index e9348fd..35a9d8c 100644
>> --- a/arch/mips/jz4740/platform.c
>> +++ b/arch/mips/jz4740/platform.c
>> @@ -329,3 +329,24 @@ struct platform_device jz4740_pwm_device = {
> [...]
>> +struct platform_device jz4740_dma_device = {
>> +    .name    = "jz4740-dma",
>> +    .id    = -1,
> 
>    Why not align all = in this structure?
> 

Will fix that in the next version, thanks.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ