| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Jun 2013 14:21:18 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Kees Cook <keescook@...omium.org> Cc: linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org Subject: Re: [PATCH] doc: avoid strncpy in accounting tool On Wed, 5 Jun 2013 19:49:30 -0700 Kees Cook <keescook@...omium.org> wrote: > Avoid strncpy anti-pattern. Use strdup() instead, as already done for > the logfile optarg. > What Andreas said :) From: Andrew Morton <akpm@...ux-foundation.org> Subject: documentation-accounting-getdelaysc-avoid-strncpy-in-accounting-tool-fix remove the str[cpy|dup] altogether Cc: Andreas Schwab <schwab@...ux-m68k.org> Cc: Kees Cook <keescook@...omium.org> Cc: Rob Landley <rob@...dley.net> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> --- Documentation/accounting/getdelays.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN Documentation/accounting/getdelays.c~documentation-accounting-getdelaysc-avoid-strncpy-in-accounting-tool-fix Documentation/accounting/getdelays.c --- a/Documentation/accounting/getdelays.c~documentation-accounting-getdelaysc-avoid-strncpy-in-accounting-tool-fix +++ a/Documentation/accounting/getdelays.c @@ -299,7 +299,7 @@ int main(int argc, char *argv[]) break; case 'C': containerset = 1; - containerpath = strdup(optarg); + containerpath = optarg; break; case 'w': logfile = strdup(optarg); _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists