| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20130610.143314.1237579707705274760.davem@davemloft.net> Date: Mon, 10 Jun 2013 14:33:14 -0700 (PDT) From: David Miller <davem@...emloft.net> To: mst@...hat.com Cc: jasowang@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] tuntap: fix a possible race between queue selection and changing queues From: "Michael S. Tsirkin" <mst@...hat.com> Date: Wed, 5 Jun 2013 13:33:32 +0300 > On Wed, Jun 05, 2013 at 04:44:57PM +0800, Jason Wang wrote: >> Complier may generate codes that re-read the tun->numqueues during >> tun_select_queue(). This may be a race if vlan->numqueues were changed in the >> same time and can lead unexpected result (e.g. very huge value). >> >> We need prevent the compiler from generating such codes by adding an >> ACCESS_ONCE() to make sure tun->numqueues were only read once. >> >> Bug were introduced by commit c8d68e6be1c3b242f1c598595830890b65cea64a >> (tuntap: multiqueue support). >> >> Reported-by: Michael S. Tsirkin <mst@...hat.com> >> Cc: Michael S. Tsirkin <mst@...hat.com> >> Signed-off-by: Jason Wang <jasowang@...hat.com> > > Acked-by: Michael S. Tsirkin <mst@...hat.com> > > This is a theoretical problem, right? > So no need for stable. Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists