| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1370843475.58124.YahooMailNeo@web160106.mail.bf1.yahoo.com> Date: Sun, 9 Jun 2013 22:51:15 -0700 (PDT) From: PINTU KUMAR <pintu_agarwal@...oo.com> To: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org> Subject: [checkpatch] - Confusion Hi, I wanted to submit my first patch. But I have some confusion about the /scripts/checkpatch.pl errors. After correcting some checkpatch errors, when I run checkpatch.pl, it showed me 0 errors. But when I create patches are git format-patch, it is showing me 1 error. If I fix error in patch, it showed me back again in files. Now, I am confused which error to fix while submitting patches, the file or the patch errors. Please provide your opinion. File: mm/page_alloc.c Previous file errors: total: 16 errors, 110 warnings, 6255 lines checked After fixing errors: total: 0 errors, 105 warnings, 6255 lines checked And, after running on patch: ERROR: need consistent spacing around '*' (ctx:WxV) #153: FILE: mm/page_alloc.c:5476: +int min_free_kbytes_sysctl_handler(ctl_table *table, int write, - Pintu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists