linux-kernel - Re: [PATCH] mfd: vexpress: Make the driver optional for arm and arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Jun 2013 00:22:49 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Pawel Moll <pawel.moll@....com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Catalin Marinas <catalin.marinas@....com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] mfd: vexpress: Make the driver optional for arm and
	arm64

On Mon, Jun 10, 2013 at 04:09:15PM +0100, Pawel Moll wrote:
> The driver can be used on either arm or arm64 platforms, but
> the latter doesn't have any platform-specific configuration
> options, so it must be possible to manually enable the driver.
> 
> As the gpiolib is optional for arm64 arch, the gpio/led code
> must be compiled conditionally.
> 
> Signed-off-by: Pawel Moll <pawel.moll@....com>
> Acked-by: Catalin Marinas <catalin.marinas@....com>
> ---
>  drivers/mfd/Kconfig           |  3 ++-
>  drivers/mfd/vexpress-sysreg.c | 10 ++++++++--
>  2 files changed, 10 insertions(+), 3 deletions(-)
> 
> Hi Samuel,
> 
> Could you please queue this small change for 3.11?

Please use #ifdef rather than a single #if defined().  #if defined()
on its own is unnecessarily ugly.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/