linux-kernel - Re: [RFC] regmap: Add regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51B57BA0.3060702@st.com>
Date:	Mon, 10 Jun 2013 08:09:20 +0100
From:	Srinivas KANDAGATLA <srinivas.kandagatla@...com>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Mark Brown <broonie@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC] regmap: Add regmap_field APIs

On 09/06/13 17:00, Lars-Peter Clausen wrote:
> [...]
>> +int regmap_field_write(struct regmap_field *field, unsigned int val)
>> +{
>> +	int field_bits;
>> +	unsigned int reg_mask;
>> +	field_bits = field->msb - field->lsb + 1;
>> +	reg_mask = ((BIT(field_bits) - 1) << field->lsb);
>> +	return regmap_update_bits(field->regmap, field->reg,
>> +				reg_mask, val << field->lsb);
> 
> Considering that you'd do the same calculations over and over again it would
> probably make more sense store the mask rather than the msb in the struct
It makes sense, I will do that change.

Thanks,
srini
> 
>> +}
>> +EXPORT_SYMBOL_GPL(regmap_field_write);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/