linux-kernel - Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 10 Jun 2013 10:00:00 +0200
From:	Michael Holzheu <holzheu@...ux.vnet.ibm.com>
To:	Maxim Uvarov <muvarov@...il.com>
Cc:	Vivek Goyal <vgoyal@...hat.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	"kexec@...ts.infradead.org" <kexec@...ts.infradead.org>,
	Jan Willeke <willeke@...ibm.com>, linux-kernel@...r.kernel.org,
	HATAYAMA Daisuke <d.hatayama@...fujitsu.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>
Subject: Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

On Sat, 8 Jun 2013 11:38:00 +0400
Maxim Uvarov <muvarov@...il.com> wrote:

[snip]

> > +static int copy_to(void *target, void *src, size_t size, int
> > userbuf) +{
> > +       if (userbuf) {
> > +               if (copy_to_user(target, src, size))
> > +                       return -EFAULT;
> > +               return 0;
> > +       } else {
> > +               memcpy(target, src, size);
> > +               return 0;
> > +       }
> > +}
> >  
> 
> It is better to do return 0 in the end of function.

Sure, I will change that.

Thanks!
Michael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/