linux-kernel - Re: [RESEND][PATCH] cpufreq: stats: Add 'load_table' sysfs file to show accumulated data of CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Jun 2013 10:36:22 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	rjw@...k.pl, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, cpufreq@...r.kernel.org,
	kyungmin.park@...sung.com, myungjoo.ham@...sung.com,
	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>
Subject: Re: [RESEND][PATCH] cpufreq: stats: Add 'load_table' sysfs file to
 show accumulated data of CPU

On 10 June 2013 17:43, Chanwoo Choi <cw00.choi@...sung.com> wrote:
> On 06/07/2013 07:23 PM, Viresh Kumar wrote:
>> On 5 June 2013 13:41, Chanwoo Choi <cw00.choi@...sung.com> wrote:

> 1301500082290 800000 61 11 1 43
>
> ...
>
> When 1301500082290 ns:
> cpu0's busy_cpu_threshold : 32 = 64 * (800000/1600000)

s/64/61 :)

>> How are you getting loads different for all your cpus? I believe you
>> are just recording these values for policy->cpu and all cpus share
>> same policy on your platform.
>>
> I got the Per-CPU load by using cpufreq_notify_transition().
> when cpufreq governor call dbs_check_cpu().

I forgot to remove this line in my earlier reply. I understood this towards
the end of patch.

>>> +#ifdef CONFIG_CPU_FREQ_STAT_DETAILS
>>> +       struct cpufreq_freqs freqs;
>>> +#endif
>> Why do you need this to be global?
> I'll remove global variable and move 'freqs' in some structure.

??

You can just make it a local variable in the only function it is used.

TIP: Always place a blank line before and after your reply to kernel
mails, this makes it much more readable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/