linux-kernel - Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51B771FC.1000203@cogentembedded.com>
Date:	Tue, 11 Jun 2013 22:52:44 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	"B, Ravi" <ravibabu@...com>
CC:	"ABRAHAM, KISHON VIJAY" <kishon@...com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Balbi, Felipe" <balbi@...com>
Subject: Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx
 platform

Hello.

On 06/11/2013 01:45 PM, B, Ravi wrote:

>>> +
>>> +	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy_wkup");
>>> +	phy->phy_wkup = ioremap(res->start, resource_size(res));

>> devm_ioremap?

> The phy_wakeup register is common across two instances of phy, devm_ioremap_resource() will fail to map for twice for same register space.

     I've already told you the register can't be shared between devices 
like this. BTW, you haven't replied to my request concerning your 
/proc/iomem contents...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/