linux-kernel - Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51B78C82.7020709@cogentembedded.com>
Date:	Wed, 12 Jun 2013 00:45:54 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
CC:	Markos Chandras <markos.chandras@...il.com>,
	Markos Chandras <markos.chandras@...tec.com>,
	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from
 VORTEX

Hello.

On 06/12/2013 12:16 AM, Paul Gortmaker wrote:

>>>> The Vortex driver depends on PCI with optional support for EISA.

>>>> This fixes build problems when EISA is selected but not PCI.

>>>> drivers/net/ethernet/3com/3c59x.c:1031:2: error: implicit declaration of
>>>> function 'pci_iomap' [-Werror=implicit-function-declaration]
>>>> drivers/net/ethernet/3com/3c59x.c:1044:3: error: implicit declaration of
>>>> function 'pci_iounmap' [-Werror=implicit-function-declaration]

>>>> Cc: David S. Miller <davem@...emloft.net>
>>>> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
>>>> Cc: netdev@...r.kernel.org
>>>> Signed-off-by: Markos Chandras <markos.chandras@...tec.com>
>>>> ---
>>>>   drivers/net/ethernet/3com/Kconfig | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)

>>>> diff --git a/drivers/net/ethernet/3com/Kconfig b/drivers/net/ethernet/3com/Kconfig
>>>> index 1c71c76..5c67f44 100644
>>>> --- a/drivers/net/ethernet/3com/Kconfig
>>>> +++ b/drivers/net/ethernet/3com/Kconfig
>>>> @@ -66,7 +66,7 @@ config PCMCIA_3C589
>>>>
>>>>   config VORTEX
>>>>        tristate "3c590/3c900 series (592/595/597) \"Vortex/Boomerang\" support"
>>>> -     depends on (PCI || EISA) && HAS_IOPORT
>>>> +     depends on PCI && HAS_IOPORT

>>> How can this fix it?  The way I read your change is that you
>>> have now made it impossible to select for EISA=y and PCI=n,
>>> thus breaking EISA only configurations who would find their
>>> driver support gone when they run "make oldconfig".

[...]

>> Hi Paul,

>> The driver does not seem to build if you only have EISA=y and PCI=n.
>> Does this driver really support EISA only

> Yes.  Not that anyone really probably cares anymore.  EISA is dead.

    We have the user of 3Com EISA cards on this list and I've fixed EISA
specific bug in this driver not long ago.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/