| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1371027934-1955-1-git-send-email-david.wiltshire@gmx.com> Date: Wed, 12 Jun 2013 19:05:31 +1000 From: Dave Wiltshire <david.wiltshire@....com> To: davem@...emloft.net Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, nsujir@...adcom.com, mchan@...adcom.com, rmody@...cade.com, jcliburn@...il.com, chris.snook@...il.com, jeffrey.t.kirsher@...el.com, bruce.w.allan@...el.com, alexander.h.duyck@...el.com, cooldavid@...ldavid.org, linux-driver@...gic.com, linux-wimax@...el.com, wimax@...uxwimax.org, linux-wireless@...r.kernel.org, viro@...iv.linux.org.uk, eparis@...hat.com, edumazet@...gle.com, dev@...nvswitch.org, jhs@...atatu.com, Dave Wiltshire <david.wiltshire@....com> Subject: [PATCH 0/3] skbuff: pskb_expand_head changes This patchset applies against David Miller's net-next tree. This is my first patch, so please let me know if I've done something wrong or could do something better (e.g. splitting the patch in a different way). I think there is a problem with memory accounting in pskb_expand_head. Some call sites update truesize while others don't. This means that the skbuff can change in size without truesize being updated. This seems incorrect to me. So I changed it. Perhaps I don't understand something, but I thought it best to generate the change and then ask. So is this correct? The other patches are from looking at all the call sites to pskb_expand_head and since I was doing that I cleaned some of them up. Dave Wiltshire (3): skbuff: Update truesize in pskb_expand_head skbuff: skb_cow_head not used in some drivers. skbuff: Added new helper function skb_cow_clone_head. drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 8 ++------ drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 8 ++------ drivers/net/ethernet/atheros/atlx/atl1.c | 8 ++------ drivers/net/ethernet/broadcom/tg3.c | 3 +-- drivers/net/ethernet/brocade/bna/bnad.c | 11 +++-------- drivers/net/ethernet/intel/e1000/e1000_main.c | 8 ++------ drivers/net/ethernet/intel/e1000e/netdev.c | 8 ++------ drivers/net/ethernet/intel/igb/igb_main.c | 7 ++----- drivers/net/ethernet/intel/igbvf/netdev.c | 11 +++-------- drivers/net/ethernet/intel/ixgb/ixgb_main.c | 8 ++------ drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 +++------- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 7 ++----- drivers/net/ethernet/jme.c | 3 +-- drivers/net/ethernet/qlogic/qlge/qlge_main.c | 8 ++------ drivers/net/wimax/i2400m/netdev.c | 3 +-- drivers/net/wireless/mwl8k.c | 1 - include/linux/skbuff.h | 14 +++++++++++++ kernel/audit.c | 2 -- net/core/dev.c | 8 ++------ net/core/skbuff.c | 1 + net/netlink/af_netlink.c | 3 +-- net/openvswitch/actions.c | 22 +++++++-------------- net/sched/act_csum.c | 8 ++------ net/sched/act_nat.c | 18 +++++------------ net/wireless/util.c | 2 -- 25 files changed, 62 insertions(+), 128 deletions(-) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists