linux-kernel - Re: [PATCH v3 1/5] pwm: Add Renesas TPU PWM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130612102223.GC30841@mithrandir>
Date:	Wed, 12 Jun 2013 12:22:24 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
Cc:	linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-leds@...r.kernel.org, Magnus Damm <magnus.damm@...il.com>,
	Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH v3 1/5] pwm: Add Renesas TPU PWM driver

On Tue, Jun 11, 2013 at 03:45:40PM +0200, Laurent Pinchart wrote:
[...]
> +static struct platform_driver tpu_driver = {
> +	.probe		= tpu_probe,
> +	.remove		= tpu_remove,
> +	.driver		= {
> +		.name	= "renesas_tpu_pwm",

You agreed to rename this to "renesas-tpu-pwm" after my review of v2.
Can you please fix that in the next version. It's the only remaining
issue: as I said, the other minor quibbles can be fixed up in a
subsequent patch.

Thierry

Content of type "application/pgp-signature" skipped