linux-kernel - Re: [PATCH] PM / Sleep: Print last wakeup source on failed wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2495031.eoWHqoAo1O@vostro.rjw.lan>
Date:	Wed, 12 Jun 2013 13:08:30 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Julius Werner <jwerner@...omium.org>
Cc:	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
	Todd Poynor <toddpoynor@...gle.com>, linux-pm@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Sameer Nanda <snanda@...omium.org>
Subject: Re: [PATCH] PM / Sleep: Print last wakeup source on failed wakeup_count write

On Tuesday, June 11, 2013 04:17:35 PM Julius Werner wrote:
> > This is going to be done in the autosleep case too, which I'm slightly
> > concerned about.
> >
> > If you wanted to cover /sys/power/wakeup_count only, it would be better
> > to put that into wakeup_count_store(), but perhaps you wanted to cover
> > autosleep too?
> >
> 
> Hmm... no, I did not really take the autosleep case into account. I can't
> quite tell with what frequency the autosleep try_to_suspend() handler on an
> active system would run... do you think it might be a useful feature to
> have there, or would it lead to logspam?

On Android systems it may be really frequent, because they try to suspend
very aggressively.  That's why I asked about it.

> I can move it to wakeup_count_store() if you prefer, but then I will have
> to turn print_active_wakeup_sources() into an exported function, which is
> also a little inconvenient.

That's OK.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/