linux-kernel - Re: [PATCH v3] pwm: add pca9685 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130612113029.GC1940@manwe>
Date:	Wed, 12 Jun 2013 13:30:30 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Steffen Trumtrar <s.trumtrar@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	kernel@...gutronix.de
Subject: Re: [PATCH v3] pwm: add pca9685 driver

On Thu, Jun 06, 2013 at 10:03:00AM +0200, Steffen Trumtrar wrote:
> On Thu, May 30, 2013 at 09:50:12AM +0200, Steffen Trumtrar wrote:
> > Add pwm driver for the NXP pca9685 16 channel pwm-led controller.
> > 
> > The driver is really barebones at this stage. E.g. the OE' pin and
> > therefore the corresponding registers are not supported.
> > The driver was tested on a HW where this pin is tied to GND.
> > 
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@...gutronix.de>
> > ---
> > Changes since v2:
> > 	- s/pwm-pca9685-led/pwm-pca9685/g
> > 	- replace DT properties with booleans
> > 	- whitespace/blank line cleanup
> > 	- add "depends on REGMAP_I2C" in Kconfig
> > 	- rework code readability
> > 	- add pwm_ops.free function
> > 	- set SLEEP bit on request/free/remove
> > 
> > Changes since v1:
> > 	- fix typo in documentation example
> > 
> >  .../devicetree/bindings/pwm/nxp,pca9685-pwm.txt    |  27 ++
> >  drivers/pwm/Kconfig                                |   9 +
> >  drivers/pwm/Makefile                               |   1 +
> >  drivers/pwm/pwm-pca9685.c                          | 291 +++++++++++++++++++++
> >  4 files changed, 328 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
> >  create mode 100644 drivers/pwm/pwm-pca9685.c
> > 
> 
> Ping ?!

Applied with some small fixups, thanks.

Thierry

Content of type "application/pgp-signature" skipped