linux-kernel - Re: [PATCH 1/1] kernel/pid.c: Masking the flag out to get the actual value.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130611182831.8d6d25be.akpm@linux-foundation.org>
Date:	Tue, 11 Jun 2013 18:28:31 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	ebiederm@...ssion.com (Eric W. Biederman)
Cc:	"Raphael S. Carvalho" <raphael.scarv@...il.com>,
	"Serge E. Hallyn" <serge@...lyn.com>,
	Serge Hallyn <serge.hallyn@...onical.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] kernel/pid.c: Masking the flag out to get the
 actual value.

On Tue, 11 Jun 2013 18:16:50 -0700 ebiederm@...ssion.com (Eric W. Biederman) wrote:

> 
> > Hopefully we can fix this one by adding the missing comment.
> 
> Perhaps we can fix this one by having people who care read the code and 
> think about what it means?

As is obvious from this thread, that approach isn't working.

>  Seriously if we are adding pids/processes in
> the pid namespace why would to clean up the pid namespace?

A good way to communicate the design would be to describe the semantics
of PIDNS_HASH_ADDING, at its definition site.

[idly wonders what the heck pid_namespace.level and pid.level do, sigh]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/