linux-kernel - Re: am335x: TSC & ADC reworking including DT pieces, take 4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130612144133.GP29135@zurbaran>
Date:	Wed, 12 Jun 2013 16:41:33 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:	Jonathan Cameron <jic23@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jonathan Cameron <jic23@....ac.uk>,
	Lee Jones <lee.jones@...aro.org>,
	Benoît Cousson <b-cousson@...com>,
	Tony Lindgren <tony@...mide.com>, Felipe Balbi <balbi@...com>,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-iio@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: am335x: TSC & ADC reworking including DT pieces, take 4

On Wed, Jun 12, 2013 at 04:02:00PM +0200, Sebastian Andrzej Siewior wrote:
> >> By keep the regmap code you mean I am allowed to remove the regmap
> >> usage in mfd (keep patch #1) or do you insist on adding its usage in
> >> iio and input?
> > I insist on keeping it on the MFD driver, i.e. _not_ keeping patch #1.
> 
> This forces me redo a few things and most likely adding it to the
> iio and input driver to be consistent here.
I'm not asking for that. The current MFD code uses regmap fine without
the iio and input using it, I don't see why you would have to add regmap
support there.

> Could you please give a reason why using the regmap here is a good
> thing? I mentioned a few why it is not and why is better to leave it
> out.
Yes, and I'm not convinced obviously. regmap prevents you from open
coding your MMIO access, and this is the right approach.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/