lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Jun 2013 09:02:15 -0700 From: Joe Perches <joe@...ches.com> To: Phil Carmody <phil.carmody@...tner.samsung.com> Cc: apw@...onical.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH] checkpatch: forgive use of mixed case variables measuring units On Wed, 2013-06-12 at 15:59 +0300, Phil Carmody wrote: > I agree that a creeping list of exceptions where CamelCase > is to be overlooked would be bad, but I would argue that > perhaps my exceptions aren't actual CamelCase - they're > (pretending to be) SI units, and just happen to match the > CamelCase regexp. I did a grep for my regexp, and everything > I noticed in a quick scan did look like a justifiable > variable name. Maybe, but this regex misses variants like: regulator_min_uA_show Maybe "^[a-z_]*_[numk][VAS](?:_\w+)?$" But this regex also does not match on other common sound variants "_dB", "_mB" and temperature like "_mC". There's also the arm bL variant (bigLittle) So I guess it'd be better to use "^[a-z_]*_[a-z][A-Z](?:_\w+)?$" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists