linux-kernel - Re: [PATCH v2] sound/sgtl5000: fix codec register initial values and mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130612160805.GL1403@sirena.org.uk>
Date:	Wed, 12 Jun 2013 17:08:05 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Fabio Estevam <fabio.estevam@...escale.com>
Cc:	Oskar Schirmer <oskar@...ra.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Zeng Zhaoming <zengzm.kernel@...il.com>,
	alsa-devel@...a-project.org, Takashi Iwai <tiwai@...e.de>,
	Jaroslav Kysela <perex@...ex.cz>
Subject: Re: [PATCH v2] sound/sgtl5000: fix codec register initial values and
 mask

On Tue, Jun 11, 2013 at 01:01:57PM -0300, Fabio Estevam wrote:
> On 06/11/2013 12:22 PM, Oskar Schirmer wrote:
> >According to documentation bit 3:2 in register SSS_CTRL are
> >reserved and zero, so initially setting the register to 0x0008
> >does not make much sense. Instead, bit 4 should be marked set,
> >as this is the power up default.
> >
> >Further, mask computation in declarative part is obviously wrong:
> >Fix FRAC DIVISOR to provide an 11 bit mask correctly.
> >
> >Signed-off-by: Oskar Schirmer <oskar@...ra.com>
> >Tested-by: Fabio Estevam <fabio.estevam@...escale.com>

> Looks good, but please copy Mark Brown. Just added him in Cc now.

Please also use subject lines matching the normal style for the
subsystem.  I can't apply this unless someone sends me a copy properly
(not quoted and so on).

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)