linux-kernel - Re: [PATCH] x86, relocs: move ELF relocation handling to C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51B8BA92.2090801@zytor.com>
Date:	Wed, 12 Jun 2013 11:14:42 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Kees Cook <keescook@...omium.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	the arch/x86 maintainers <x86@...nel.org>,
	David Woodhouse <David.Woodhouse@...el.com>,
	Matt Fleming <matt.fleming@...el.com>,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	Pekka Enberg <penberg@...nel.org>
Subject: Re: [PATCH] x86, relocs: move ELF relocation handling to C

On 06/12/2013 11:13 AM, Yinghai Lu wrote:
> 
> it seems those lines for x86_64 are never used.
> as X86_NEED_RELOCS is not defined for x86_64
> 
>>  config X86_NEED_RELOCS
>>         def_bool y
>>         depends on X86_32 && RELOCATABLE
> 
> 
>> +}
>> +#else
>> +static inline void handle_relocations(void *output, unsigned long output_len)
>> +{ }
>> +#endif
> 
> Can you make it clear that this patch only affect x86_32 in patch title?
> 

I am not sure this belongs in the patch title, as it is preparatory work
for x86-64.  It should be mentioned in the patch description body, though.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/