lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Jun 2013 13:16:42 -0700 From: Sören Brinkmann <soren.brinkmann@...inx.com> To: Steffen Trumtrar <s.trumtrar@...gutronix.de> CC: Michal Simek <michal.simek@...inx.com>, Russell King <linux@....linux.org.uk>, <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>, Dinh Nguyen <dinguyen@...era.com>, Olof Johansson <olof@...om.net>, Shawn Guo <shawn.guo@...aro.org> Subject: Re: [PATCH v2 3/3] arm: dt: zynq: Add support for the zed platform On Wed, Jun 12, 2013 at 09:33:58PM +0200, Steffen Trumtrar wrote: > On Wed, Jun 12, 2013 at 11:26:34AM -0700, Sören Brinkmann wrote: > > On Wed, Jun 12, 2013 at 08:23:45PM +0200, Steffen Trumtrar wrote: > > > On Wed, Jun 12, 2013 at 09:41:08AM -0700, Soren Brinkmann wrote: > > > > Add a DT fragment for the Zed Zynq platform and a corresponding > > > > target to the Makefile > > > > > > > > Signed-off-by: Soren Brinkmann <soren.brinkmann@...inx.com> > > > > --- > > > > I used the 'xlnx,...' compat strings since it seems this is what is > > > > used in the Xilinx and Digilent vendor trees. > > > > > > > > +/include/ "zynq-7000.dtsi" > > > > + > > > > +/ { > > > > + model = "Zynq Zed Development Board"; > > > > + compatible = "xlnx,zynq-zed", "xlnx,zynq-7000"; > > > > + > > > > + memory { > > > > + device_type = "memory"; > > > > + reg = <0 0x20000000>; > > > > + }; > > > > + > > > > + chosen { > > > > + bootargs = "console=ttyPS1,115200 earlyprintk"; > > > > + }; > > > > + > > > > +}; > > > > > > Hi! > > > > > > This looks a little bit to basic. No?! Not even an UART? > > The UART is imported from the common zynq-7000.dtsi. > > Hm, you are actually right, although I think that you shouldn't be. > It is possible to NOT use the UARTs, isn't it? So, default on for both UARTs is wrong. Well, in that case the dtsi has to be fixed to add the 'status = "disabled" property to the UARTs which then can be overridden in the board dts files as needed. I guess I'll prepare another patch for a v3 for adding status properties to the UART nodes. > > > > > > The compatible should include digilent or avnet. Digilent only sells to academic > > > customers, Avnet doesn't. > > I don't care at all. So, who makes the decision which one is the correct > > one? Actually we could even drop the zed specific one completely and go > > with 'xlnx,zynq-7000' only. > > I'm okay with that. Okay, let's wait a little and see if there are other opinions and then I can prepare a v3. Sören -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists